Java: FT.EXPLAIN and FT.EXPLAINCLI #2515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chloe <chloe.yip@improving.com>
Signed-off-by: Chloe Yip <chloe.yip@improving.com>
Signed-off-by: Chloe <chloe.yip@improving.com>
Signed-off-by: Chloe <chloe.yip@improving.com>
java/client/src/main/java/glide/api/commands/servermodules/FT.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/FT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Chloe <chloe.yip@improving.com>
Signed-off-by: Chloe <chloe.yip@improving.com>
Signed-off-by: Chloe <chloe.yip@improving.com>
acarbonetto
reviewed
Oct 25, 2024
java/client/src/main/java/glide/api/commands/servermodules/FT.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/FT.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/FT.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/servermodules/FT.java
Outdated
Show resolved
Hide resolved
| assertTrue(exception.getMessage().contains("Index not found")); | ||
| } | ||
|
|
||
| @SneakyThrows |
There was a problem hiding this comment.
nit: instead, you can throw on the method signature
java/integTest/src/test/java/glide/modules/VectorSearchTests.java
Outdated
Show resolved
Hide resolved
java/integTest/src/test/java/glide/modules/VectorSearchTests.java
Outdated
Show resolved
Hide resolved
| // search query containing numeric field. | ||
| String query = "@price:[0 10]"; | ||
| String result[] = FT.explaincli(client, indexName, query).get(); | ||
| List<String> resultList = new ArrayList<>(); |
There was a problem hiding this comment.
As an interesting exercise, you can use Stream() to map result to a result list. Something like:
List<String> trimmedResult = result.stream().map(::trim).collect(Collection.toList());
There was a problem hiding this comment.
unfortunately streams only work on lists
There was a problem hiding this comment.
Arrays.stream() works on arrays. I'll point you to an example, and IntelliJ has a lot of hints to help create streams.
| assertTrue((resultListGS).contains("0")); | ||
| assertTrue((resultListGS).contains("10")); | ||
|
|
||
| resultListGS.clear(); |
There was a problem hiding this comment.
just use a new variable. memory is cheap
Signed-off-by: Chloe <chloe.yip@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2428
Checklist
Before submitting the PR make sure the following are checked: